pkiraly / qa-catalogue-web

QA Catalogue / A data quality dashboard for MARC catalogues
GNU General Public License v3.0
10 stars 6 forks source link

Ensure code quality with PHPStan #191

Open nichtich opened 4 months ago

nichtich commented 4 months ago

As noted in #143, there should be continuous integration scripts. I added composer scripts to executed PHP lint, static code analysis with PHPStan, and unit tests localed in tests/ with PHPUnit. To fully enable it, there are a couple of errors detected by PHPStan (run composer analyse to get a full list):

More warnings will come up when increasing --level of PHPStan in composer.json, but I think level 0 is enough to start with.

nichtich commented 4 months ago

Note to self: add a pre-push-hook so failing tests and analysis is never pushed.