search

pkiraly / qa-catalogue-web

QA Catalogue / A data quality dashboard for MARC catalogues
GNU General Public License v3.0
10 stars 6 forks source link

Replace error_log with logger to support log levels #193

Closed nichtich closed 3 months ago

nichtich commented 4 months ago

Setting logLevel configuration does not affect error_log. All 70 calls to error_log should be replaced by calls to the logger (see $this->log->...).

pkiraly commented 4 months ago

You are right.

pkiraly commented 3 months ago

@nichtich I changed in the main, "tab" classes. There are some static functions used by the dashboard, where I kept error_log in the first round - probably the index.php should create a global logger, that can be used by these and the auxiliary functions. I also improved the README a bit.

nichtich commented 3 months ago

In general globals should be avoided, but having a global logger object seems legit.

pkiraly commented 3 months ago

Now error_log() calls are purged out of the tool.