pkiraly / qa-catalogue

QA catalogue – a metadata quality assessment tool for library catalogue records (MARC, PICA)
GNU General Public License v3.0
78 stars 17 forks source link

Enable to import both Avram and "Yale" format of schema files #373

Closed pkiraly closed 4 months ago

pkiraly commented 10 months ago

This is needed for the inclusion of #371.

nichtich commented 10 months ago

No need to do so, as the Yale format is being changed to comply to Avram specification.

nichtich commented 6 months ago

Is class YaleMarc21SchemaReader still used? As far as I understand, both the class and src/main/resources/marc/authority-schema.yale.json are only used in test class YaleMarc21SchemaReaderTest but not on production, so they can be removed?

pkiraly commented 6 months ago

The analysis based on the authority schema is not yet in production, but only used in test classes (following a test driven development version). I think you are right, the YaleMarc21SchemaReader could be removed shortly.