Open nichtich opened 11 months ago
I've released Avram specification 0.9.3 with validation options renamed to better match error types/options of QA Catalogue. Differences to be resolved still:
hasInvalidValue
to invalidValue
(nonEmptyIndicator
and hasInvalidValue
of INDICATOR to invalidIndicator
or add an option invalidIndicator
to enable/disable bothcontrolValueContainsInvalidCode
and invalidReference
to undefinedCode
or add an option undefinedCode
to enable/disable bothIn addition there are validation options not supported by QA Catalogue yet, but this is optional unless full support of arbitrary Avram Schemas is promised.
The Avram specification contains a list of validation rules to check (AR1...AR24, but only AR1..AR16 are mandatory) and a list of validation options to enable/disable selected error types. These roughly correspond to QA catalogue validation error types. I'd like to align the error type codes used in QA catalogue and Avram specification. The QA catalogue error type codes with correspondence in Avram are:
undefinedField
ignore_unknown_fields
nonrepeatableField
ignore_nonrepeatable_fields
(TBD)undefinedSubfield
ignore_unknown_subfields
nonrepeatableSubfield
ignore_nonrepeatable_subfields
(TBD)missingSubfield
ignore_missing_subfields
(TBD)nonEmptyIndicator
ignore_indicators
(TBD)hasInvalidValue
ignore_indicators
(TBD)patternMismatch
ignore_patterns
(TBD)hasInvalidValue
ignore_values
hasInvalidValue
ignore_values
controlValueContainsInvalidCode
ignore_codes
invalidReference
ignore_codes
Avram further has AR4 (
missigField
), the other Avram Rules seem to be already covered by QA Catalogue.Questions:
hasInvalidValue
is duplicated in categories CONTROLFIELD, INIDCATOR, and SUBFIELD, is this right? I'd better call itinvalidValue
instead ofhasInvalidValue
to align with naming of other error codes.missingSubfield
of category DATAFIELD seems to cover only field880$6
but this should be about any missing required subfield, right? Maybe we don't have any other required subfields so far.ignore_missing_subfields
tomissingSubfields
.