Nonfiling characters in indicator values

pkiraly / qa-catalogue

QA catalogue – a metadata quality assessment tool for library catalogue records (MARC, PICA)

GNU General Public License v3.0

76 stars 18 forks source link

Nonfiling characters in indicator values #402

Open nichtich opened 5 months ago

nichtich commented 5 months ago

Field 086, 130, 222, 240, 242, 243, 245, 440, 630, 730, 740, and 830 have indicator definition with codes 0-9 or 1-9, e.g. this. It's a verbatim copy from MARC 21 specification but the actual codes are each of 0,1,2,3...9 instead of the sequence 0-9 or 1-9 (an indicator is only one character anyway). I wonder this has not shown up before on validation.

Solutions:

either explicitly list 0 to 9
or use a pattern ([0-9]) instead of codes

nichtich commented 5 months ago

I've started to implement this but

changing src/main/java/de/gwdg/metadataqa/marc/definition/tags/tags20x/Tag245.java indicator codes to pattern will make src/test/java/de/gwdg/metadataqa/marc/definition/tags/tags20x/Tag245Test.java fail. I think resolveIndicator in src/main/java/de/gwdg/metadataqa/marc/dao/DataField.java needs to be extended to also handle indicator definitions with pattern.
Similar seems to apply for Tag440 and Tag740.

pkiraly commented 1 month ago

[ ] Investigate this.