search

pkissling / clock-weather-card

A Home Assistant Card indicating today's date/time, along with an iOS inspired weather forecast for the next days with animated icons
Other
397 stars 78 forks source link

Added display of humidity to Today section, along with configuration #337

Closed rakasha681 closed 6 months ago

rakasha681 commented 6 months ago

Resolves #273

Added display of humidity to Today section below weather/temp, along with configuration for sensor and option hide_humidity. Updated readme to match latest changes. No style changes and placed in a way that conforms with overall feel of current card design.

Changes to be committed: modified: src/clock-weather-card.ts to add display and method to obtain humidity, along with config modified: src/types.ts to add required types for changes modified: README.md to include the new options

pkissling commented 6 months ago

all good, thanks for the PR. please fix the lint issues (https://github.com/pkissling/clock-weather-card/actions/runs/8253081526/job/22601291054?pr=337), so that i can merge the changes and create a release.

one thing which i am thinking about, is that the default hide_humidity: true should become show_humidity: false, otherwise it would imply that the humidity is shown by default, which is not true. what do you think?

rakasha681 commented 6 months ago

I was thinking the same thing. Changed that, and fixed the lint. Glad to help out, not too bad for my first PR ever, and first time using TS :)