pkjaer / tridion-powershell-modules

Windows PowerShell module allowing management of SDL Tridion (Content Management System) from the command line
13 stars 14 forks source link

Hard coded the max value for MaxReceiveMessageSize #26

Closed DominicCronin closed 7 years ago

DominicCronin commented 7 years ago

I started by making this configurable, but that's just adding complexity for no reason. This version just hard codes it to the max value. This quota is only to prevent dos attacks, so assuming we're only ever going to use the module to talk to genuine Tridion core services, we don't really need any limit here. If you really want the other version, it's on another branch, but my view is that this rather simple hack is a better solution.

pkjaer commented 7 years ago

Thanks!

pkjaer commented 7 years ago

It turns out that it cannot be a long, but has to be an integer (because the client buffers messages). Anyway, I updated it to int MaxValue after I merged it in.