search

pkkid / x11pygrid

Quickly move windows around the an X11 desktop
GNU General Public License v2.0
324 stars 41 forks source link

Titlebar disappears when maximizing window #3

Closed dol closed 6 years ago

dol commented 8 years ago

The title bar of an window disappears when maximizing a window that was resize with pyGrid.

Reproduce the issue:

  1. Open new window
  2. Unmaximize window
  3. Use Ctrl+Alt+5 to align/resize window
  4. Maximize the window

    Expected

screenshot_2016-10-10_22-50-49

Actual

screenshot_2016-10-10_22-50-18

dol commented 8 years ago

Additional informations:

pkkid commented 8 years ago

Interesting. It sounds like I'll have to spin up a VM with XFCE on it. If you don't mind a minor code change, I suspect commenting out line 181 (window.set_shadow_width(0,0,0,0)) might fix the issue? It's the only place I feel like I'm doing something dirty. That line is a workaround for bug #1 dealing with window shadows on newer Gnome apps.

If that's not it, I'll need to look elsewhere.

dol commented 8 years ago

Commenting out window.set_shadow_width(0,0,0,0) solved the problem. Now a workaround of a workaround is needed. workaround

pkkid commented 6 years ago

This is slightly icky, but maybe the best option for now is to have a configuration option to enable or disable the shadow workaround we need for Gnome but you don't want on XFCE. I'm going to dupe this bug to the other one since they are basically dealing with the same line of code.

See: https://github.com/pkkid/pygrid/issues/1