search

pkkid / x11pygrid

Quickly move windows around the an X11 desktop
GNU General Public License v2.0
324 stars 41 forks source link

Modified method of forcing single instance. Now it will support FreeBSD (maybe all BSDs). #39

Closed SP5D closed 2 years ago

SP5D commented 2 years ago

Tested on FreeBSD and Linux. Old locking method didn't work on FreeBSD at all (as well as probably on any other BSD). New works on Linux as good as the old one, while on FreeBSD it also(!) protects from trying to run second PyGrid instance even from the other location! On Linux both locking methods don't protect from that – it's possible to run multiple instances from multiple directories. It should never be the case, but it's worth to notice.

pkkid commented 2 years ago

Does this now require we install the single_process package? If so, we should update the readme, and maybe consider adding a requirements.txt file?

SP5D commented 2 years ago

Yep, it's required.

Totally agree! Last year I've proposed even more than requirements.txt file – it should be package uploaded to PyPi. (My propose/issue: https://github.com/pkkid/pygrid/issues/29) I haven't done it myself, because IMHO it should be connected to your PyPi account. I know, code is GPL-2.0, but that's more about personal culture. It's mostly your work and should be connected to your account.

I can make it a PyPi package and upload, no problem, but NOT without your permission and blessing ;)

pkkid commented 2 years ago

Thanks for these changes and sorry the last proposal slipped by me. Feel free to do whatever with PyPi. If you need me to approve or bless something, consider it done. For now, I'll merge this PR and add the additional requirement to the readme since it still moves the package forward. :)

SP5D commented 2 years ago

Ok then, I'm going to make package soon! Thanks! :)