search

pkl-community / setup-pkl

Apache License 2.0
5 stars 4 forks source link

Support windows and macos runners #6

Closed StefMa closed 3 months ago

StefMa commented 6 months ago

Right now only Linux runners are supported. I guess this action should support all default runners (windows and macos). Pkl supports all of these (windows via Java and macos as native binary). However, the Java binary is not yet published as a release, but next release.

jasongwartz commented 6 months ago

@StefMa Great point! Yes indeed, I've hard-coded "pkl-linux-amd64" here: https://github.com/pkl-community/setup-pkl/blob/main/src/main.ts#L31 but would love to support other runners. I think it would just be a matter of implementing similar templating logic as here: https://github.com/pkl-community/node-packages/blob/main/pkl/src/index.ts#L8

PRs very welcome!

StefMa commented 6 months ago

Hey @jasongwartz ,

I played around with it a bit. I created a PR on my fork, to verify that it works: https://github.com/StefMa/setup-pkl/pull/1

But for some reasons the Github Actions doesn't run... Do you know why? 🤔

jasongwartz commented 6 months ago

@StefMa Looks like this is something people have encountered before, eg: https://github.com/orgs/community/discussions/50736

I just tried it out and forked this repo, went to the Actions tab, and saw this screen:

image

So perhaps you have to enable them in your fork on the Actions tab?

StefMa commented 6 months ago

Yay! That worked. Thanks for the hint!

On Sat, Mar 30, 2024, 1:26 PM Jason Gwartz @.***> wrote:

@StefMa https://github.com/StefMa Looks like this is something people have encountered before, eg: https://github.com/orgs/community/discussions/50736

I just tried it out and forked this repo, went to the Actions tab, and saw this screen: image.png (view on web) https://github.com/pkl-community/setup-pkl/assets/10981911/0c096c9b-0912-45b7-9f7e-1fa1c2fb5052

So perhaps you have to enable them in your fork on the Actions tab?

— Reply to this email directly, view it on GitHub https://github.com/pkl-community/setup-pkl/issues/6#issuecomment-2028035853, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACOBQ63EXYEQB4MOJP5WRNTY22VOVAVCNFSM6AAAAABEV4M5COVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRYGAZTKOBVGM . You are receiving this because you were mentioned.Message ID: @.***>