pklaus / brother_ql_web

A Python-based web service to print labels on Brother QL label printers. Based on brother_ql: https://github.com/pklaus/brother_ql
GNU General Public License v3.0
254 stars 124 forks source link

set dpi_600 to True by default #47

Open larsfroelich opened 1 year ago

larsfroelich commented 1 year ago

The dpi_600 setting allows improved print quality at the expense of speed. However, it's still very fast and can significantly improve contrast on the prints, so I argue it should be enabled by default. This could also be a checkbox somewhere in the UI later down the line.

larsfroelich commented 1 year ago

see also this line in brother_ql https://github.com/pklaus/brother_ql/blob/56cf4394ad750346c6b664821ccd7489ec140dae/brother_ql/conversion.py#L60

FriedrichFroebel commented 10 months ago

AFAIK, this breaks die cut labels due to mismatching dimensions (https://github.com/pklaus/brother_ql/blob/56cf4394ad750346c6b664821ccd7489ec140dae/brother_ql/conversion.py#L102 https://github.com/pklaus/brother_ql/blob/56cf4394ad750346c6b664821ccd7489ec140dae/brother_ql/conversion.py#L125-L126), while for endless labels, this seems to downscale the image to 150 dpi and then upscale it to 300 dpi again: https://github.com/pklaus/brother_ql/blob/56cf4394ad750346c6b664821ccd7489ec140dae/brother_ql/conversion.py#L109-L113