pkluz / PKHUD

A Swift based reimplementation of the Apple HUD (Volume, Ringer, Rotation,…) for iOS 8.
MIT License
3.79k stars 494 forks source link

Switch podspec to use resource bundle for asset catalog #235

Closed robinkunde closed 6 years ago

robinkunde commented 6 years ago

The way Cocoapods integrates asset catalogs from pods that don't use resource bundles into apps is currently slightly broken and unnecessarily increases build times. Cocoapods essentially recompiles the app's main asset catalog to include all asset catalogs from pods, but the process is not reliable and has to be done on every build, even if nothing's changed.

This PR switches PKHUD to using resources bundles instead.

I've tested the changes with the demo project, Carthage, and Cocoapods using both dynamic and static frameworks and didn't find any issues.