search

pkluz / PKRevealController

PKRevealController is a delightful view controller container for iOS, enabling you to present multiple controllers on top of one another.
Other
3.85k stars 659 forks source link

Gesture recognizers not correctly placed #87

Closed adammj closed 11 years ago

adammj commented 11 years ago

Gestures switched: Method - (void)setRecognizesResetTapOnFrontView, sets and unsets the panGesture. Method - (void)setRecognizesPanningOnFrontView, sets and unsets the tapGesture.

tapGesture cannot currently be disabled as suggested, because it is always added back (regardless of recognizesResetTapOnFrontView) in - (void)showLeftViewControllerAnimated and - (void)showRightViewControllerAnimated.

adammj commented 11 years ago

On the same subject, can you also add the ability to have the panGesture only enabled when the left or right is being revealed similar to how you always add the tapGesture, but with tested conditionals for both? I don't like having the panGesture enabled when only the frontView is showing, as I want the reveal button to be pressed first. However, I do like having the ability to swipe the frontView back into place. (I've already made the changes, but I'd like to make future diffs with your codebase easier)

pkluz commented 11 years ago

Fixed the placing. If I understood correctly the issue should be resolved. - Regarding your second point (let's call it lazy-panning). That's a great idea. Mind opening a separate issue for this?