search

pkmital / CADL

ARCHIVED: Contains historical course materials/Homework materials for the FREE MOOC course on "Creative Applications of Deep Learning w/ Tensorflow" #CADL
https://www.kadenze.com/courses/creative-applications-of-deep-learning-with-tensorflow/info
Apache License 2.0
1.48k stars 732 forks source link

lecture 4 : isn't there an issue with h,w ; in cell 31 ? #92

Closed vichug closed 6 years ago

vichug commented 6 years ago

Cell 31 of the lecture notebook shows :

def total_variation_loss(x):
    h, w = x.get_shape().as_list()[1], x.get_shape().as_list()[1]

Shouldn't it be :

def total_variation_loss(x):
    h, w = x.get_shape().as_list()[1], x.get_shape().as_list()[2]

?

pkmital commented 6 years ago

Good catch! I guess we better include some non-square images in our tests ;) Feel free to open a PR if you want or else I will be sure to include this in the next update.

vichug commented 6 years ago

PR opened :)