@pkmn/data: Merge `Learnsets.learnable` data for evolved species

pkmn / ps

Modular Pokémon Showdown

MIT License

110 stars 16 forks source link

@pkmn/data: Merge `Learnsets.learnable` data for evolved species #15

Closed te1 closed 2 years ago

te1 commented 2 years ago

Fixes #14

This is a naive merge that only prevents exact duplicates.

It leads to this learnset for gen 8 Venusaur and Double-Edge: ['8L51', '8L45', '8L33'] because it now has the data for Venusaur, Ivysaur and Bulbasaur.

Special handling could be added for Lx to prevent that. I'm not so sure what should be done about Sx (special event distributions) which could have a similar issue.

scheibo commented 2 years ago

Going to land this and try to iterate on it! Thanks for the detailed bug report and provided fix (with tests!)