Closed wTheRockb closed 2 years ago
Thanks for your interest in the project!
The current display is somewhat intentional - the extension tooltip displays all possible options for items/abilities/moves, unlike the native PS tooltip which shows what the actual revealed information is. An alternative (which is the direction you appear to be heading in this PR) is to have the extension tooltip display just the remaining possible options, though if that were the case it should filter to only show remaining possible items/abilities as well to avoid creating confusion as to what the extension displays ( and which is more difficult. Furthermore, in all cases you would probably want to remove the row entirely for one of the data types if there were no remaining options).
I'm hesitant to change the definition of the extension's tooltip information from "all" -> "remaining" possible options, as the latter is more complicated to both code and for a user to immediately grok, and given the large number of users this extension now supports (> 10k) I'm reluctant to move things around too much. I'm not sure the clutter/readability argument is super strong as this only removes 1-4 moves from the list, and I don't know that screen real estate is at that much of a premium (though apparently some people are using this on their phones...).
Finally, I view this extension as mostly a "finished product", with something like EPOké/PocketMon eventually being the actual logical progression for improving the display here, and am likely only going to be willing to accept changes to add formats or keep up to date with breaking changes from upstream.
Roger that, very reasonable. And agree, this would be inconsistent if we didn't do the same with items, and would increase code complexity. Thanks for the reply + consideration!
This changes the possible moves displayed to no longer include moves that are already known, in an effort to improve readability and reduce clutter.