search

pkmn / randbats

Pokémon Showdown's Random Battle sets
https://pkmn.github.io/randbats/
MIT License
30 stars 13 forks source link

Make the update script multithreaded #4

Closed gigalh128 closed 1 year ago

gigalh128 commented 1 year ago

It does run faster starting from 10K+, but the code is kinda ugly, so...

scheibo commented 1 year ago

Nice job taking a crack at this idea! As a general rule, if youre going to propose a change for performance reasons its helpful to show what the before vs. after time is to help the reviewer better evaluate whether (hopefully improved) runtime from the additional complexity is worth the maintenance burden.

scheibo commented 1 year ago

Closing since its been 2 weeks without updates. Please feel free to reopen in the future if you plan to continue working on this. :)