pkmn / stats

Pokémon Showdown battle log processing and usage stats generation logic
MIT License
6 stars 1 forks source link

Use @pkmn/sets Team.canonicalize instead of a bespoke canonicalizeTeam #8

Open scheibo opened 2 months ago

scheibo commented 2 months ago

The existing canonicalizeTeam needs to be preserved until legacy mode is removed, but https://github.com/pkmn/ps/blob/5917828dd3c00598a9f2422e26129334a2bf38a6/sets/src/sets.ts#L361 should be preferred. As noted in the comment, we might also think to dedupe based on computed stats and not just bucketed EVs/IVs. If @pkmn/sets is missing features then it should be augmented.