Open asherkin opened 3 years ago
@pkmnct it looks like you were prodding some of this in #17, any chance this could get reviewed / merged?
@pkmnct it looks like you were prodding some of this in #17, any chance this could get reviewed / merged?
Hey! Sorry for the delay, I commented some suggestions but this overall is looking sensible!
This fixes #8
@pkmnct it looks like you were prodding some of this in #17, any chance this could get reviewed / merged?
Hey! Sorry for the delay, I commented some suggestions but this overall is looking sensible!
Heya - I can't see them I'm afraid!
If they're in a review, double-check the whole review was submitted at the top of the page 😄
Only add the TelevisionSpeaker service if we have a device with mute state implemented (which is required for TelevisionSpeaker), which simplifies the UI displayed in HomeKit for things that only have a power state.
Additionally, the empty array checks in the Homebridge callbacks weren't working as it turns out
[]
is truthy - which was causing Homebridge to complain that the callback was never called. This check shouldn't actually be needed any more with the first change, but I fixed that before realising the service could be removed completely.I ran into this troubleshooting a warning from Homebridge:
with a very basic config for my projector: