search

pkmnct / robinhood-mint-sync-chrome

A browser extension that allows you to sync Robinhood and Mint
https://pkmnct.github.io/robinhood-mint-sync-chrome/
MIT License
53 stars 7 forks source link

Improve waitForElement utility, fix property setup when no properties present #27

Closed superpowered closed 3 years ago

superpowered commented 3 years ago

https://github.com/pkmnct/robinhood-mint-sync-chrome/issues/17#issuecomment-761906397

Currently if the user is in a "Zero State" (They have 0 properties on the account) the Add Property Button can not be clicked. This adds some functionality to waitForElement to check for fail states, and allows a failure callback.

Also fixes some buttons being incorrectly clicked on create. (prefers to now use the element returned from waitForElement, and filters down a bit more)

Adds some more debug logs to the various steps.

pkmnct commented 3 years ago

@superpowered I made a new issue to track this: #31. I have some additional bug fixes in #24 that I'd like to release at the same time, so I'm going to update your PR to target that branch.

pkmnct commented 3 years ago

@superpowered I've fixed the merge issues and done some small cleanup, but I'll do a more in-depth review soon.