search

pkmnfrk / equivalentintegrations

Equivalent Integrations - expanding EMC to the rest of the Minecraft ecosystem
Other
7 stars 4 forks source link

EMC for offline players is not managed correctly #26

Closed pkmnfrk closed 5 years ago

pkmnfrk commented 5 years ago

I'm not 100% sure on the reproduction steps, but it seems that the following scenarios are busted:

  1. EMC is reported as 0 while a player is offline
  2. An offline player whose EMC mutated while offline (eg, changed from 0 per item 1) will have that new value overwrite their real EMC value

This is a big deal, since this is a primary use case, and can result in losing a lot of EMC.

pkmnfrk commented 5 years ago

Actually, it's even worse. Right now, I reproduced it on a test server, but having logged in as the affected player, it's continually locking my EMC to 0. Hm.

Actually, I just had another source consuming EMC faster than I was adding it. The other issues still stand

pkmnfrk commented 5 years ago

It seems that ProjectE, at some point, stopped reporting offline players' EMC correctly. So, as with other things, I've made it stop trusting it, and use our own cache.