pkmnfrk / equivalentintegrations

Equivalent Integrations - expanding EMC to the rest of the Minecraft ecosystem
Other
7 stars 4 forks source link

v0.4.3 is not compatible with ProjectE 1.4.0 #32

Closed pkmnfrk closed 5 years ago

pkmnfrk commented 5 years ago

@pkmnfrk This is still an issue for me in v0.4.3

https://pastebin.com/d46qrYeG

I should note, this only happens when you look at a block. I looked at cobblestone and it happened.

Originally posted by @Elmegaard in https://github.com/pkmnfrk/equivalentintegrations/issues/31#issuecomment-487142144

pkmnfrk commented 5 years ago

Just like between ProjectE 1.3.0 and 1.3.1, ProjectE made a significant API change between point releases (sinkillerj/ProjectE#1818), breaking compatibility. Fortunately, I'm more prepared this time, so I won't have to make two versions again. But, man, the ghost of semver is crying in its grave

pkmnfrk commented 5 years ago

Oops, I forgot that trying to have compatibility for two versions is very hard, which is why I didn't try last time.

This time, I'm not making two versions. Instead I'm just going to increase the minimum version to 1.4.1.

pkmnfrk commented 5 years ago

This is "resolved" in v0.4.4, which is identical to v0.4.3, except it has a newer minimum PE version.