pkmnfrk / equivalentintegrations

Equivalent Integrations - expanding EMC to the rest of the Minecraft ecosystem
Other
7 stars 4 forks source link

Lots of lag after extended play #5

Closed pkmnfrk closed 6 years ago

pkmnfrk commented 6 years ago

Unsure if this is EI or another mod, but after playing for a while (3-4 hours), the game starts hanging for about 3 seconds every 10 seconds. I think it's severe GC, which might be due to the fact that we throw out the cached knowledge array any time it changes, which can potentially happen at least a few times every tick.

pkmnfrk commented 6 years ago

I've completely redone how the inventory is calculated, and centralized it per player (since it's going to be the same for every chamber). This should greatly reduce the memory pressure, if indeed this is what was causing it. But, I need to do a few hours of testing to confirm

pkmnfrk commented 6 years ago

I left the game running for about 5 hours, and when I came back, it was basically unresponsive. Investigating the logs, the following is true:

This is definitely a memory leak of some kind, but I'm not sure where it's coming from. I'm having a hard time believing that it's this mod, since I basically removed all dynamic allocations other than ItemStacks. What could it be?

pkmnfrk commented 6 years ago

I have conclusively determined that it was Optifine, not this mod. Ironic, yes.