search

pkolaczk / fclones

Efficient Duplicate File Finder
MIT License
1.87k stars 70 forks source link

workaround for sysinfo build failures on trueNAS freebsd 12 system #117

Closed up2geek closed 2 years ago

up2geek commented 2 years ago

I'm not sure how well this will work elsewhere, but it appears to have worked for me.

up2geek commented 2 years ago

Ah nice. it appears your build-and-test pipeline has identified a few more areas that need updating...

I might be completely out of my depth here, but I'm going to attempt it for my own installation at the very least.

up2geek commented 2 years ago

Just to be clear I have no experience with rust or this project before today, so I fully admit that I may have missed something major here, but I'm so glad to have this working on my TrueNAS/freebsd system and hope it helps others.

I have done small tests with duplicate test files, but I'm about to fire off big job and see how the performance compares to fdupes and others.

up2geek commented 2 years ago

@pkolaczk - ah... looks like there is a 'is_removable' function in the new version... I'm not concerned with removable drives at the moment so the current changes worked in the build I'm using at the moment, but this would ensure it stays compatible. https://docs.rs/sysinfo/0.23.10/sysinfo/trait.DiskExt.html#tymethod.is_removable

Just want to say thanks for this tool, I've already cleaned up close to a TB of data using it. It's working well 👍

pkolaczk commented 2 years ago

Merged with minor cleanup in #118.