search

pkolaczk / fclones

Efficient Duplicate File Finder
MIT License
1.99k stars 79 forks source link

v0.29.0 clap upgrade to 4.0 results with --help not using colours anymore #169

Closed kapitainsky closed 2 years ago

kapitainsky commented 2 years ago

e.g., fclones group --help

v0.28.0 on macOS and Debian:

colours

v0.29.0 - no more colours:

bq
kapitainsky commented 2 years ago

Maybe it is intentional but IMHO colours make --help much easier to read.

pkolaczk commented 2 years ago

This is intentional.

During clap 3.0.0 development, we were looking at removing AppSettings::ColoredHelp, making it always on. This helped identify several problems with our existing colored help and started a broader re-examination of our --help output. For more background on each decision, I recommend you check out the parent issue

Problems with the colored help The choice of colors was controversial, some liked it but others hated it. We want safe out-of-the-box defaults Some applications have a specific branding to their color choices and clap's colors don't fit within that, so they would rather have none instead

Actually many (most?)) apps don't use colors in help, but just bold or different shades of gray/white.

kapitainsky commented 2 years ago

Thank you for explanation. Fair enough.