search

pkorotkov / google-coredumper

Automatically exported from code.google.com/p/google-coredumper
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

linux/dirent.h removed from kernel #2

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Hello, I had been packaging coredumper and one issue comes. The file
linux/dirent.h has been removed from linux kernel hearders (at least for
fedora latest rawhide kernel).

header file defines two structs
#ifndef _LINUX_DIRENT_H
#define _LINUX_DIRENT_H

struct dirent {
        long            d_ino;
        __kernel_off_t  d_off;
        unsigned short  d_reclen;
        char            d_name[256]; /* We must not include limits.h! */
};

struct dirent64 {
        __u64           d_ino;
        __s64           d_off;
        unsigned short  d_reclen;
        unsigned char   d_type;
        char            d_name[256];
};

#endif

If you can confirm that this is not case with kernel headers and is
specially a problem for fedora kernel.

Then I will patch the package specially, but if it is other way round, then
you may consider fixing the issue.

Regards,
rakesh

Original issue reported on code.google.com by rakesh.p...@gmail.com on 25 Aug 2008 at 5:06

GoogleCodeExporter commented 9 years ago 
i did a bit more investigation and found that in place of linux/dirent.h should 
now
be using dirent.h already in includedir provided by glibc headers.

Original comment by rakesh.p...@gmail.com on 25 Aug 2008 at 10:31

Attachments:

GoogleCodeExporter commented 9 years ago 
ping?
I am impatiently waiting for update.

Original comment by rakesh.p...@gmail.com on 30 Aug 2008 at 6:15

GoogleCodeExporter commented 9 years ago 
I think my patch is wrong. We need to check which dirent and dirent64 
structures does
kernel use now. If it used glibc header structures then no need to do structure 
checking.

Original comment by rakesh.p...@gmail.com on 30 Aug 2008 at 6:34

GoogleCodeExporter commented 9 years ago 
ping? ping?
I am getting bit impatient?????

Original comment by rakesh.p...@gmail.com on 31 Aug 2008 at 5:59

GoogleCodeExporter commented 9 years ago 
I just submitted a change that removed all references to linux/dirent.h. Let me 
know,
if you still run into any other problems.

Original comment by zod...@gmail.com on 31 Aug 2008 at 6:03

GoogleCodeExporter commented 9 years ago 
Okay Thanks I will build now and report in few mins

Original comment by rakesh.p...@gmail.com on 31 Aug 2008 at 6:23

GoogleCodeExporter commented 9 years ago 
Confirmed! 
It is working and Fixed.

Original comment by rakesh.p...@gmail.com on 31 Aug 2008 at 7:05