search

pkoshevoy / aeyae

apprenticevideo (video player), aeyae remux (video remuxer), yaetv (digital video recorder), yamka (matroska format toolkit), yathe (legacy code for 3D geometry transforms, bezier curves, spline curves, and UI abstraction layers)
22 stars 6 forks source link

Apprentice Video does not contain any version numbers on macOS #5

Closed core-code closed 5 years ago

core-code commented 5 years ago

both the CFBundleShortVersionString and CFBundleVersion entry in the Info.plist file are empty.

all macOS apps are supposed to contain valid version information.

pkoshevoy commented 5 years ago

This key is required by the App Store and is used throughout the system to identify your app's released or unreleased build.

I don't offer anything through the app store

core-code commented 5 years ago

of course Apple can only make 'requirements' for apps distributed inside the Mac App Store. apps not distributed there can just crash all the time for all for all Apple cares - this doesn't mean crashing is a good idea.

users certainly expect each proper Mac app to have a proper version number that can be viewed in the Finder. this means adding the CFBundleShortVersionString and CFBundleVersion keys.

the CFBundleVersion key is especially important as it defines which version will be launched when multiple versions are installed. obviously the newest one should be launched. the operating system can only determine 'newest' if the 'CFBundleVersion' key is properly populated with a version number or build number.

also, the CFBundleGetInfoString has been deprecated for more than 10 years and should be removed.

pkoshevoy commented 5 years ago

I still provide builds for OSX 10.5 PPC, so I think I'll keep CFBundleGetInfoString

pkoshevoy commented 5 years ago

I'll look into adding CFBundleVersion, but as I don't follow semantic versioning the major/minor/patch are going to be mostly hard-coded and derived from git commit date

core-code commented 5 years ago

awesome thanks

pkoshevoy commented 5 years ago

Fixed in git.replay.20190804.133243.5f5c8e6

core-code commented 5 years ago

i can confirm this is fixed, thanks