search

pkp / authorRequirements

A plugin for OJS
GNU General Public License v3.0
4 stars 8 forks source link

OJS 3.3 compatibility #11

Closed withanage closed 2 years ago

withanage commented 2 years ago

@ewhanson

Hi Eric, for TIB work, I was testing this plugin and had to change small things to make it compatible for OJS 3.3. If this would break and you would like create a seperate branch for stable-3_3_0, I will create a seperate PR.

ewhanson commented 2 years ago

Thanks @withanage.

I'm happy to keep compatibility for 3.3 on the main branch until there are breaking changes for 3.4 added. I also have an open issue for adding in PHP 8.0 support, so I'll have a look at this and that, then get another release ready.

Out of curiosity, were the issues you ran into related to PHP versions or changes in OJS?

withanage commented 2 years ago

Thanks @ewhanson

the changes I made were related to OJS 3.3 compatibility. They were minor. I think PHP 8 compatibility is already there in the plugin

ewhanson commented 2 years ago

Thanks again @withanage! All looks good. Would you be able to update the PR to use space instead of tabs? Also a good reminder I should run the whole plugin through the code formatter in OJS to bring its styles in line with the rest of the code base.

withanage commented 2 years ago

@ewhanson , sure, I have changed the indentation to spaces.

ewhanson commented 2 years ago

Thanks, @withanage!