pkp / bootstrap3

A community-built theme for OJS 3 that implements Bootstrap 3 components.
GNU General Public License v3.0
55 stars 98 forks source link

Copyright Notice - edit link broken #169

Closed israelcefrin closed 2 months ago

israelcefrin commented 3 years ago

When a logged user attempts to edit "Copyright Notice" section, clicking on "edit" link from frontend interface, it takes the user to a blank screen.

The reason is pointing to: /management/settings/journal#policies when the correct link should be: /management/settings/distribution#permissions

The edit link is shown in "Submission" page of the journal.

image

NateWr commented 3 years ago

What version of OJS and Bootstrap3?

israelcefrin commented 3 years ago

OJS version: 3.1.1.0 Bootstrap: 1.1.4.0

NateWr commented 3 years ago

I don't think that we'll fix it for 3.1.x. can you reproduce the problem in 3.3.x?

On Mon, 31 May 2021, 15:18 Israel Cefrin, @.***> wrote:

OJS version: 3.1.1.0 Bootstrap: 1.1.4.0

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NateWr/bootstrap3/issues/169#issuecomment-851521859, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARTERIFKJJB3CHVK3CCZHTTQOLDRANCNFSM45XNK7BQ .

israelcefrin commented 3 years ago

OJS 3.3 shows similar issues using the Bootstrap theme. I've tested on the test-drive install:

https://demo.publicknowledgeproject.org/ojs3/testdrive/index.php/testdrive-journal/about/submissions

There is not a "copyright notice", but either "Submission Preparation Checklist " and "Author Guidelines" are showing broken links when logged.

kaitlinnewson commented 2 months ago

@asmecher I have a small change ready for review to fix this - will forward-port if all looks good:

asmecher commented 2 months ago

Merged, thanks -- please go ahead!

kaitlinnewson commented 2 months ago

@asmecher Additional PRs ready for merge and linked above.

asmecher commented 2 months ago

Merged, thanks, @kaitlinnewson! Is this ready to be closed?

kaitlinnewson commented 2 months ago

@asmecher Yes, ready to close!

asmecher commented 2 months ago

Thanks!