pkp / bootstrap3

A community-built theme for OJS 3 that implements Bootstrap 3 components.
GNU General Public License v3.0
55 stars 98 forks source link

Readable theme contains not readable color selection #192

Closed dogsleg closed 2 months ago

dogsleg commented 1 year ago

Hi,

thanks for your work on Bootstrap Theme for OJS.

Readable theme has a color selection for "Make a new submission or view your pending submissions". Please, see the screenshot attached.

Readable

NateWr commented 1 year ago

Thanks for reporting this @dogsleg. I don't have time to address this now but I will try to get a fix for this in when a refactor the theme for 3.4.

kaitlinnewson commented 2 months ago

Fix ready for this, which will add the alert-link class to links in alert boxes. This improves the display of links across all of the sub-styles as well.

Readable theme with fix (see screenshot above for before):

Screenshot 2024-06-27 at 11 31 46 AM

Alerts for user registration form before (Readable theme):

Screenshot 2024-06-27 at 11 40 13 AM

Alerts for user registration form with fix (Readable theme):

Screenshot 2024-06-27 at 11 39 54 AM

@asmecher PR ready for review - will forward-port if all looks good:

asmecher commented 2 months ago

^ Merged, thanks, @kaitlinnewson!

kaitlinnewson commented 2 months ago

@asmecher Additional PRs linked above and ready for review.

asmecher commented 2 months ago

Both merged, thanks! Now that you've got permissions on this repo, you can use your discretion to decide whether ports need additional review; if not, feel free to git cherry-pick them forward.