search

pkp / bootstrap3

A community-built theme for OJS 3 that implements Bootstrap 3 components.
GNU General Public License v3.0
55 stars 98 forks source link

Article preview fails if no issue assigned #226

Closed jnugent closed 1 week ago

jnugent commented 2 weeks ago

The theme fails in numerous places if an issue is not assigned and previewing is attempted.

For example:

https://github.com/pkp/bootstrap3/blob/stable-3_4_0/templates/frontend/components/breadcrumbs_article.tpl#L31

generates a fatal error because the $issue object is null. Also, e.g. here:

https://github.com/pkp/bootstrap3/blob/stable-3_4_0/templates/frontend/objects/article_details.tpl#L279

There are other places. Spotted in 3.3 but I am linking to 3.4 versions of the plugin as the problem exists throughout.

kaitlinnewson commented 2 weeks ago

PR to 3.3 ready for review @asmecher - changes are based on the default theme templates:

Forward-porting PRs:

asmecher commented 2 weeks ago

Thanks, @kaitlinnewson, please go ahead! I've merged the stable-3_3_0 PR.

kaitlinnewson commented 1 week ago

Merged to 3.3/3.4/main and assigned for the next release, closing.