search

pkp / citationStyleLanguage

An OJS 3 plugin to generate an article citation in any CSL citation style using citeproc-php.
GNU General Public License v2.0
15 stars 53 forks source link

Upgrade citation-style files for 3.3.0 release #91

Closed JhonathanLepidus closed 2 years ago

JhonathanLepidus commented 2 years ago

Related to the issues https://github.com/pkp/pkp-lib/issues/5629 and https://github.com/pkp/pkp-lib/issues/6700

JhonathanLepidus commented 2 years ago

Some of the citation-style files were not upgraded correctly. We're going to fix them as soon as possible.

asmecher commented 2 years ago

@NateWr, could you take a look at this?

JhonathanLepidus commented 2 years ago

The citation-style files were upgraded in order to match with the corresponding files in the v1.0.2 branch of CSL.

NateWr commented 2 years ago

Thanks for this @JhonathanLepidus, and especially for upgrading to CSL 1.0.2. :+1:

@asmecher what is your feeling about this change for stable-3_3_0? Should we only update CSL styles at the main branch or is this safe enough to update for stable-3_3_0? It seems like there are some significant updates.

asmecher commented 2 years ago

I would prefer targeting only main for significant updates, but if you're really interested in stable-3_3_0 updates being distributed and can do a side-by-side comparison of the main formats (listed in CitationStyleLanguagePlugin::getCitationStyles) before and after the changes, I'm open to updating them.

asmecher commented 2 years ago

If it helps, I checked with SciELO and 3.3.0 is not a huge priority for them; they're content to wait for 3.4.0. But the above still applies if it's a priority for you outside of SciELO's work!