search

pkp / classic

An official theme for OJS 3.1.1+
GNU General Public License v2.0
11 stars 27 forks source link

Display announcements homepage #22

Closed sssoz closed 5 years ago

sssoz commented 5 years ago

...and some markup updates for better a11y.

Closes #11

sssoz commented 5 years ago

@natewr, @Vitaliy-1

Since none of the themes are using breadcrumbs, I’m wondering if it’s necessary to use the template named breadcrumbs.tpl: https://github.com/pkp/classic/blob/master/templates/frontend/components/breadcrumbs.tpl

It creates a <nav>, which is unnecessary in this context.

NateWr commented 5 years ago

The default theme does use that template, but I don't know about Classic or any other themes.

sssoz commented 5 years ago

This one does, but I will rename it.

Also trying to avoid changing these templates too much, since the theme has been released already and all. Would need to refactor a lot of the markup.