search

pkp / classic

An official theme for OJS 3.1.1+
GNU General Public License v2.0
11 stars 27 forks source link

Display homepage image & journal summary #37

Closed sssoz closed 5 years ago

sssoz commented 5 years ago

Close #32, #28

Suggesting in this PR to display both the homepage image and homepage journal summary in the same block. These changes can anticipate the four following cases:

  1. User only selects the homepage image to be displayed → it is displayed as a background image, taking up a minimum of 25% of the height of the user’s viewport.

    Screen Shot 2019-08-07 at 13 13 06

  2. User only selects the journal summary to be displayed → it is displayed, in black text, with some margins around it to make it stand out from the header and the rest of the page.

    Screen Shot 2019-08-07 at 13 13 42

  3. User selects both options to be enabled → we darken the background image and display the journal summary’s text in white, to make it stand out.

    Screen Shot 2019-08-07 at 13 12 51

  4. User selects both options to be disabled → nothing is displayed.

    Screen Shot 2019-08-07 at 13 16 08
sssoz commented 5 years ago

@AhemNason Tagging you here so you can check out these changes once they’ve been merged

AhemNason commented 5 years ago

this looks rad

Vitaliy-1 commented 5 years ago

Ahh, I see that I've duplicated some comments from @NateWr :)

NateWr commented 5 years ago

Ahh, I see that I've duplicated some comments from @NateWr :)

My mistake! I normally leave these to you so I should have said I was taking a quick look.

Vitaliy-1 commented 5 years ago

@sssoz, if substituting gunmetal color, some work needs to be done regarding color inversion. E.g., you can test the problem by picking a whitish color from a dashboard and hover on view all issues button on the journal index or issue page. Do you want to work on it on this branch or make a new PR?

sssoz commented 5 years ago

@sssoz, if substituting gunmetal color, some work needs to be done regarding color inversion. E.g., you can test the problem by picking a whitish color from a dashboard and hover on view all issues button on the journal index or issue page. Do you want to work on it on this branch or make a new PR?

I will make a new PR! That gunmetal colour wouldn’t work with many user-selected colours (and I might've mistakenly included in the original mockups back then -- and meant to use a dark grey instead). I will make more thorough colour testing, as we did with Pragma!