search

pkp / classic

An official theme for OJS 3.1.1+
GNU General Public License v2.0
11 stars 27 forks source link

Use baseColour option that’s already used in Default theme #46

Closed sssoz closed 5 years ago

sssoz commented 5 years ago

Trying to harmonise the variables we use -- Default’s baseColour already has a label and corresponds to the same concept.

NateWr commented 5 years ago

This will break the colors that people have already set when the theme is updated. Any existing primaryColour setting will not be found and so the fallback color will kick in.

Each theme's options are saved independently. So if someone has saved a baseColour setting in the default theme, it won't be found and used here.

I think it's ok for the setting names to not be identical here. In a perfect world, we'd be :100: consistent. But in reality once code goes into production, there are trade-offs to making these kinds of changes.

sssoz commented 5 years ago

Ah that’s too bad! Good to know though. Does that mean it is also too late for Pragma? https://github.com/pkp/pragma/pull/52

NateWr commented 5 years ago

Pragma hasn't yet been released to the plugin gallery so there shouldn't be any examples of it in use on live sites. I've merged that one but I'll close this one.