Make sure all text is readable when using black as primary colour

[sssoz]

In particular, tagit results:

...primary menu items are also not visible on hover for of the same reason (tested with #8fd427)

[Vitaliy-1]

Associated thread on the forum: https://forum.pkp.sfu.ca/t/classic-theme-header-colour/57757

[sssoz]

@Vitaliy-1 I think the thread on the forum is asking for two things:

1. The ability to change the header colour
2. Make sure that dark colours primary colours are still readable in the header (this issue)

I didn’t plan to do (1) but we could consider it; we would then let users define two different colours for their website (which might not always look nice): a primary colour (for links, buttons, footer background) and a header colour. What do you think?

[Vitaliy-1]

As a minimum, I saw others making changes into the header background-color for this theme (through CSS); plus the Default theme has such an option. So, I'd rather vote for adding this feature.

[NateWr]

It's up to you whether you want to add an option to set the header colour. Just know that when you add a feature like this, it is your responsibility to make sure that it works regardless of what option the user selects. When they make modifications with their own CSS, they take responsibility for making it work. So this is really a question of the level of maintenance effort you want to sustain over time for this theme. It's perfectly reasonable to say no if you want.

A middle-ground is to offer a couple of set colours, like white and black, which restricts the use-cases you need to test and lowers your maintenance burden, but allows people some configuration.

[sssoz]

Thanks, both of you! The "preselected" colours sounds like a good option to explore.