search

pkp / classic

An official theme for OJS 3.1.1+
GNU General Public License v2.0
11 stars 27 forks source link

pkp/pkp-lib#6478 Don't use CDN for fonts/script assets #91

Closed NateWr closed 3 years ago

NateWr commented 3 years ago

@Vitaliy-1 can you double-check that this looks ok?

NateWr commented 3 years ago

Oh, I see that I will need to build the LESS files using gulp. @Vitaliy-1 would you be able to do that with this and the other themes if I prepare the changes?

Vitaliy-1 commented 3 years ago

@NateWr, it's not necessary here. I compile with Gulp only npm dependencies. Thanks! I have a feeling that I've removed a dependency from ionicons, otherwise, I'm wondering why I'm not using Gulp for compiling it, will check.

Vitaliy-1 commented 3 years ago

Looks good! Do you have time to correct a small typo and I'll take care of the rest?

NateWr commented 3 years ago

Good catch! All fixed.

Vitaliy-1 commented 3 years ago

Thanks, merged!