Possibly incorrect string concatenation for XML name

[t-mayer]

Dear pkp-Team, we were trying to deposit a large number of articles (ca. 100). However, the deposit action was resulting in errors. According to the error logs, the error message said that the file name was getting too long. After debugging I've noticed that the filename part is basically being reused with every iteration of the for-loop:

$objectsFileNamePart = $objectsFileNamePart . '-' . $object->getId();

Compared to the datacite plugin (where the variable is named $objectFileNamePart):

$objectFileNamePart = $objectsFileNamePart . '-' . $object->getId();

Not sure if this is only an issue with our installation or if I am missing something...

OJS Version: 3.3.0.3 crossref-Plugin version: 2.1.0.0

Best, Tina

[bozana]

PRs:

• ojs stable-3_3_0: https://github.com/pkp/ojs/pull/3845
• crossref-ojs: https://github.com/pkp/crossref-ojs/pull/31
• ojs: https://github.com/pkp/ojs/pull/3846 (only submodule update)
• crossref-ops: https://github.com/pkp/crossref-ops/pull/27
• ops: https://github.com/pkp/ops/pull/498 (only submodule update)

[bozana]

Thanks @t-mayer! Please see the PR (ojs stable-3_3_0) for the fix.