search

pkp / customLocale

Fine-tune the language of OPS, OJS, or OMP without modifying files or changing it for everyone.
GNU General Public License v3.0
0 stars 18 forks source link

modifications for OJS 3.1.2, fix role bug, application-dependent path #1

Closed mpbraendle closed 6 months ago

asmecher commented 5 years ago

Thanks, @mpbraendle! I made a few suggestions and broke the changes out of a single commit where they weren't relevant to the main issue (the path fix). My other concern is about the path change is that it'll mean existing users of the plugin need to manually move contents -- this should be noted in the plugin documentation. (Plugins don't yet have a good toolset for update scripts; that's on my list.) Would you mind adding a note to the documentation?

asmecher commented 4 years ago

@mpbraendle, please have a look at https://github.com/pkp/pkp-lib/issues/5169 -- this is preparatory work for the plugin to be released in a form compatible with OJS 3.2, but it should cover all of this as well.

mpbraendle commented 4 years ago

@asmecher - will do, but is OJS 3.2 required to test it? Looks like that in the new version all phrase files have a new format.

asmecher commented 4 years ago

Yes, that PR will require OJS 3.2 -- we're releasing that in about a month.

asmecher commented 4 years ago

@mpbraendle, just dusting off this old PR; have you explored the version of this plugin that's available in the Plugin Gallery (for new OJS/OMP/OPS releases)? Is this still relevant?

mpbraendle commented 4 years ago

@asmecher Just upgraded yesterday a single-journal installation to OJS 3.2.1 - this went smooth without any hassles. However, customLocale is not required there. The multijournal platform where some journals use customLocale will be upgraded early August - and we will test the plugin then.