Closed jonasraoni closed 2 years ago
@jonasraoni, in the future could you separate your changes into multiple commits to keep issues like e.g. reformatting and copyright updates separate from substantive coding changes? It's really hard to review code when it's a mixture of changes specific to the issue and trivial changes that get mixed in.
Thanks, @jonasraoni! I added some comments on this, but also, since these changes will break 3.3.0 compatibility: could you create a stable-3_3_0
branch from the current main
(before this is merged) and adapt .travis.yml
so that the tests run with that version of OJS instead of main
?
Also, the Travis tests are failing here against main
; could you have a look at that too?
@asmecher I rebased the other PRs to organize the commits, but forgot about this one... I can do it later if you still didn't review it properly.
/pkp-lib
submodule, so I'll need to update the code to load the others)p.s.: As an unrelated note, I think the OPS should be pinned in the https://github.com/pkp :)
I created the stable-3_3_0
branch and adjusted .travis.yml
to point to that branch of OJS. Don't worry about reorganizing the commits, just for next time -- it's a lot less time-consuming if you do that as you work on the code, rather than afterwards!
Thanks! I was organizing the commits in the beginning, but then my one-commit guy alter ego came back into the game 😂
I basically just updated the plugin to work with the https://github.com/pkp/pkp-lib/issues/6328. So, the interface will require some updates to support the plurals.
I can work on the plural support and also address the https://github.com/pkp/customLocale/issues/7, but as we don't have plurals in the locale files yet, this can be delayed yet.