make plugin usable at site level in branch "stable-3_3_0"

pkp / customLocale

Fine-tune the language of OPS, OJS, or OMP without modifying files or changing it for everyone.

GNU General Public License v3.0

0 stars 18 forks source link

make plugin usable at site level in branch "stable-3_3_0" #14

Closed edelm closed 6 months ago

edelm commented 2 years ago

According to #11 , I made the suggested changes and tested them. This pull requests prevents the crashing of OJS, when using the plugin at site level.

eddoff commented 2 years ago

A comment on this PR after my issue: https://github.com/pkp/pkp-lib/issues/8371#issuecomment-1291921129

I tested the PR and it works. However the intention was to update the locales on site level as described here: https://docs.pkp.sfu.ca/translating-guide/en/customize-locale#example-customize-the-current-issue-label-on-homepage

You might need to change that translating guide example then if the plugin does not support changes in site level.

edelm commented 6 months ago

can we merge this request?

asmecher commented 6 months ago

@edelm, I've merged the PR, and ported it forward to stable-3_4_0 and main -- but I think more work will be needed before the plugin will behave as expected site-wide.