Update the plugin to work with the next release (3.4.0)

[jonasraoni]

The https://github.com/pkp/customLocale/pull/12 was slightly outdated when it was merged and requires minor updates to get into a working state.

PR

• https://github.com/pkp/customLocale/pull/16

[jonasraoni]

@asmecher I've added the PR to the top of the issue.

p.s.: the build is probably going to fail: I still need to update the pkp-lib of OJS to the latest and check if the cypress spec is ok after my updates (probably not).

[asmecher]

Thanks, @jonasraoni, I've read through the code and it looks good -- a rewrite was probably necessary. Please get the tests working and then I'll give it a spin from a user standpoint.

[jonasraoni]

@asmecher I've updated the PR (added namespaces, added OPS to the test matrix, added customized translation to the search), and now the tests are passing.

Do you know if this plugin is used mostly to correct and fill missing translations? If yes, perhaps we can create another issue to integrate it with Weblate somehow (a direct link next to the locale key or at least a mention saying the best long-term solution is to update the information on weblate).

I'll probably raise a side conversation about upgrading plugins in the chat.

[asmecher]

Do you know if this plugin is used mostly to correct and fill missing translations? If yes, perhaps we can create another issue to integrate it with Weblate somehow (a direct link next to the locale key or at least a mention saying the best long-term solution is to update the information on weblate).

No, I think the most common use case is wording tweaks that the journal wants to make without modifying the .po files directly. And I'd rather we encourage Weblate as a direct path for missing translations, rather than mixing the two use cases into this plugin, which would probably lead to muddled submissions to Weblate.

[asmecher]

Merged; I think this is OK to close, thanks!