search

pkp / defaultTranslation

This plugin displays English translation if the current UI language translation doesn't exist.
GNU General Public License v3.0
4 stars 9 forks source link

Update the plugin to work with the next release (3.4.0) #9

Closed jonasraoni closed 2 years ago

jonasraoni commented 2 years ago

At this moment the plugin is using a non-existent hook and depending on code that doesn't exist anymore. It must be updated to work with the current code at the /main branch of OJS/OPS/OMP.

PR:

jonasraoni commented 2 years ago

Hi @asmecher, here's the PR to address the localization updates.

jonasraoni commented 2 years ago

Is it useful to add an option to fallback to a similar language before English? Then a missing translation for pt_BR, could attempt to find a match in pt_PT, before moving to en_US.

jonasraoni commented 2 years ago

Also, I've merged this PR into mine one: https://github.com/pkp/defaultTranslation/pull/8, so you can close it =]

asmecher commented 2 years ago

Thanks!

jonasraoni commented 2 years ago

@asmecher You forgot to merge the PR (or perhaps misunderstood my previous message) 😁

I meant that you can close the PR from @kant (https://github.com/pkp/defaultTranslation/pull/8) once my PR gets merged.

asmecher commented 2 years ago

OK, gotcha -- closed that PR and re-opened this issue.

asmecher commented 2 years ago

Is it useful to add an option to fallback to a similar language before English? Then a missing translation for pt_BR, could attempt to find a match in pt_PT, before moving to en_US.

I haven't heard a specific call for this, but I could see it being useful for dialects that don't differ much from existing widely-used translations. If it's not much code to add, yes, please do.

jonasraoni commented 2 years ago

@asmecher I just addressed the comment above, so this PR is ready as well.