search

pkp / immersion

An official theme for OJS 3.1.1+
GNU General Public License v2.0
10 stars 24 forks source link

Dot (.) into 'templates/frontend/objects/issue_toc.tpl' at line 33 #25

Closed sourcedump closed 4 years ago

sourcedump commented 4 years ago

Hello!

not sure if this little issue is with this template or some translation files, but with some languages (eg. Italian) this dot between the translate key "issue.no" and the "$issue->getNumber":

<span class="issue__number">{translate key="issue.no"}. {$issue->getNumber()|escape} </span>

of the file 'templates/frontend/objects/issue_toc.tpl' make the final result like this:

No.. 5

Which one do you think should be corrected?

Thanks

asmecher commented 4 years ago

@sourcedump, I think that's best corrected by adding the . to the English locale text and removing it from the template. I've made the changes in the OJS stable-3_1_2 and master branches and starting with OJS 3.1.2-2 the change will be made there; I've also committed it here to the master branch. Many other languages already have equivalent punctuation in the locale keys and I've left them in place. Thanks for reporting!