Closed israelcefrin closed 1 year ago
In 3.4.0, the SectionDAO
has been removed and it has moved to the new Repository/DAO/Map pattern , check https://github.com/pkp/pkp-lib/issues/7128 .
The core plugin file ImmersionThemePlugin.inc.php
need some update regarding of replacing the old SectionDAO calls to new repository pattern implementation .
@Vitaliy-1 PR to review immersion --> https://github.com/pkp/immersion/pull/86
Thanks, @touhidurabir! I'm wondering, how did tests miss that... Was this SectionDAO refactoring merged after themes release for 3.4?
Thanks @touhidurabir ! I've patched my installation with the PR and now it is working perfectly.
Merged!
Describe the bug After upgrading an installation from OJS 3.3 to OJS 3.4 the journal stops to work on the frontend when Immersion Theme is enabled. It returns an error code 500
To Reproduce Steps to reproduce the behavior:
Expected behavior Loading the public interface.
Desktop (please complete the following information):
Additional context Apache log error message: