Closed asmecher closed 1 year ago
Thanks @asmecher for review!
Sorry :fearful: I forgot to add! @ipula and @withanage, thanks for this, it's always bothered me that we've been building XML with string concatenation. It's finicky work and I really appreciate your willingness to rearrange it painfully based on review feedback!
@ipula and @withanage, this PR replaces https://github.com/pkp/jatsTemplate/pull/26.
It also adds...
->parentNode
; placement of attributes first; etc)htmlspecialchars
/ escapingmeta-value
should not be nested inmeta-name
$submission->getLocale()
should never be null$ccBadge
misplaced$ccBadge
misplacedappendChild
applied to wrong element; sections data not included in DOMkwd
should not havexml:lang
attributeSome of these are trickier to catch in review than they are while coding! It pays to work on this kind of code progressively -- modify, test, rinse and repeat, with data in your installation that exercises each piece of code you touch. Be careful with copy/paste; I think a number of weird typos came in that way.