pkp / jatsTemplate

Basic JATS document template generator plugin for OJS
GNU General Public License v3.0
9 stars 13 forks source link

Change JATS document creation to a DOM based model #29

Closed asmecher closed 1 year ago

asmecher commented 1 year ago

@ipula and @withanage, this PR replaces https://github.com/pkp/jatsTemplate/pull/26.

It also adds...

Some of these are trickier to catch in review than they are while coding! It pays to work on this kind of code progressively -- modify, test, rinse and repeat, with data in your installation that exercises each piece of code you touch. Be careful with copy/paste; I think a number of weird typos came in that way.

withanage commented 1 year ago

Thanks @asmecher for review!

asmecher commented 1 year ago

Sorry :fearful: I forgot to add! @ipula and @withanage, thanks for this, it's always bothered me that we've been building XML with string concatenation. It's finicky work and I really appreciate your willingness to rearrange it painfully based on review feedback!