pkp / jatsTemplate

Basic JATS document template generator plugin for OJS
GNU General Public License v3.0
9 stars 12 forks source link

Display of multilingual keywords dependent on UI language #44

Closed ewhanson closed 2 months ago

ewhanson commented 3 months ago

When including multilingual keywords in the generated JATS, Journal::getSupportedLocales() is used to determine which languages should be included. This uses the underlying key of supportedLocales as a setting name in in the journal_settings table in the database, which make sense. However, there is a mismatch of expectations in the language used in the code/db and the language used in the frontend, which expresses itself a checkbox to enable a language for the UI of the site (in contrast to forms and submission). This tying of a "supported UI" presentation framing to a "supported locales" framing makes ambiguous which localized keywords should be included.

To answer

Solution

Use Context::getSupportedSubmissionLocales() instead, as this will match the available locale options for adding submission metadata.

ewhanson commented 3 months ago

One possibility is to use the supportedSubmissionLocales instead of the UI-forward supportedLocales.

ewhanson commented 2 months ago

PRs:

ewhanson commented 2 months ago

Merged!