Update for compatibility with stable-3_4_0 and main

pkp / openid

OpenId plugin for OJS, OMP, OPS

GNU General Public License v3.0

0 stars 2 forks source link

Update for compatibility with stable-3_4_0 and main #1

Open asmecher opened 10 months ago

asmecher commented 10 months ago

@defstat

PRs

Branch main PKP-LIB: pkp/pkp-lib#10083 openID: pkp/openid#5

Branch stable-3_4_0 PKP-LIB: pkp/pkp-lib#9621 openID: pkp/openid#3

For stable-3_4_0 we could use the main branch's PR and release the stable-3_4_0 from main branch (if everything turns out to work as they suppose to)

defstat commented 9 months ago

@asmecher thanks for your 1st round of review. I have resolved all of your comments. Find individual related responses to each of your comments.

asmecher commented 6 months ago

Thanks, @defstat! I'm adding comments to all the PRs above, and in case there's a risk of comments being applied to only one branch and not the other, all comments should be considered in both branches. I'll try to remember to note them otherwise.