[OJS] orcidProfile Plugin: ORCID integration in User Register form broken

[nils-stefan-weiher]

Hi everyone and especially @Vitaliy-1 ,

@asmecher send an error message via teampkp Slack and I found out, that in 3.1.2 the orcidProfile Plugin integration with the User Registration form is completely broken.

• [x] Pre-fill of the form fields is not working because of the name changes, see OrcidHandler.inc.php#L137-L138 (Fixed: https://github.com/pkp/orcidProfile/commit/54bd2e8843ddd5ed6bd575a330db921c0f288517 -AS)
• [x] the handler method for the "registrationform::execute" hook OrcidProfilePlugin.inc.php#L385 is also broken because of changes to the execute function signature of the form, the user object is no longer passed as an argument to the hook. I still have no idea how to access the user in this hook, because now the local "$user" variable wont get passed to the "parent::execute" call, which in turn calls the hooks. (See https://github.com/pkp/orcidProfile/pull/66 for stable-3_1_2, and https://github.com/pkp/orcidProfile/commit/5d864b8953d10511aa61701285339f2064aa2d06 and https://github.com/pkp/pkp-lib/commit/e192a4d663417475bbd009b53dea6638be5060c3 for master. - AS)

I probably need some help in fixing this, as I am also working on other stuff.

Just wanted to put that issue out there, so that the bug is known and I don't forget to work on it.

Greetings from Heidelberg,

Nils

[Baytan]

I was also going to open an issue about this. We just upgraded to OJS 3.1.2. Some authors of our journal complain that they cannot register to the journal as new user. After I disabled the Orcid plugin, registering can be made. Interestingly, when Orcid plugin is enabled, I cannot assign articles to issues. When I disable it, I can.

Thanks for the contributors of the OJS. Best regards.

[nils-stefan-weiher]

Interestingly, when Orcid plugin is enabled, I cannot assign articles to issues. When I disable it, I can.

This was fixed with an updated version which was made available yesterday, see this pull request https://github.com/pkp/orcidProfile/pull/62

[Baytan]

@isgrim Thank you for your interest and reply. I will look into it. However, user registration problem is still prevent use of this plugin for the time being. Regards.

[nils-stefan-weiher]

Yes, I am still thinking of a good solution to this, because there is another usability issue with user registration. Currently the ORCID is also not stored as authenticated, because the access token is not submitted with the user registration, the whole registration process with the ORCID plugin needs more work, but I did not have more time to put into this.

[asmecher]

I fixed the name field population in https://github.com/pkp/orcidProfile/commit/54bd2e8843ddd5ed6bd575a330db921c0f288517, which was trivial so I've committed it to stable-3_1_2 and master.

As for the hook behaviour change, I've opened a PR for that: https://github.com/pkp/orcidProfile/pull/66 Could you review this, @isgrim?

@NateWr's suggestion is a better long-term solution, so this will just be for the stable-3_1_2 branch (so we can release an updated version of the plugin with this working).

I took a quick look and it seems that the other ::execute functions aren't affected by the change in hook parameters, but your confirmation would be great, @isgrim!

Thanks, all...

[asmecher]

As for master, I've committed pkp/orcidProfile@5d864b8 and e192a4d so that $registrationForm->user is exposed to the hook and picked up by the orcid profile plugin's hook registrant function.