search

pkp / orcidProfile

A plugin to pull ORCID information into a PKP user profile
GNU General Public License v3.0
16 stars 50 forks source link

Move changes of 3.3 to 3.4 #229

Open withanage opened 1 year ago

jonasraoni commented 1 year ago

I just saw this XML validation issue at the build output of /main:

./plugins/generic/orcidProfile/emailTemplates.xml:14: element email: validity error : Element email does not carry attribute name
t="emails.orcidCollectAuthorId.subject" body="emails.orcidCollectAuthorId.body"/
                                                                               ^
./plugins/generic/orcidProfile/emailTemplates.xml:15: element email: validity error : Element email does not carry attribute name
AuthorAuthorization.subject" body="emails.orcidRequestAuthorAuthorization.body"/
withanage commented 1 year ago

Thanks @jonasraoni I think it is because the submodule update is not yet happened. Only the plugin was updated.

jonasraoni commented 1 year ago

I've been doing some general fixes on OJS, and found a missing method on the plugin, here's the PR:

Only the first commit is relevant, the rest is mostly typehinting.